DosTips.com

balubeto wrote:Does anyone know how to solve my problem in a more suitable form?

Thanks

Bye

balubeto wrote:Hi

I created a bat file with parameters that must be entered from the command line.

I would like this script is stopped with a personalized message if it will run without any parameters or with the wrong number of parameters.

So, how do I do this?

Thanks

Bye

Compo wrote:I would use something similar to this:

Code: Select all

If %1' Equ ' (Echo=You didn't enter any parameters.
   GoTo :Qend)

If %5' NEq ' (Echo=Too many parameters entered.
   GoTo :Qend)

If %4' Equ ' (Echo=Insufficient parameters entered.
   GoTo :Qend)

Rem Other code below here



:Qend
Echo=Press any key to exit. . .
Timeout -1 1>Nul
Exit/B

Just bear in mind that his only checks the number, not the correctness, of parameters.

Compo wrote:

balubeto wrote:Does anyone know how to solve my problem in a more suitable form?

Thanks

Bye

balubeto wrote:Hi

I created a bat file with parameters that must be entered from the command line.

I would like this script is stopped with a personalized message if it will run without any parameters or with the wrong number of parameters.

So, how do I do this?

Thanks

Bye

Compo wrote:I would use something similar to this:

Code: Select all

If %1' Equ ' (Echo=You didn't enter any parameters.
   GoTo :Qend)

If %5' NEq ' (Echo=Too many parameters entered.
   GoTo :Qend)

If %4' Equ ' (Echo=Insufficient parameters entered.
   GoTo :Qend)

Rem Other code below here



:Qend
Echo=Press any key to exit. . .
Timeout -1 1>Nul
Exit/B

Just bear in mind that his only checks the number, not the correctness, of parameters.

I already did!

balubeto wrote:I do not understand:

When I press only the Enter key when the script displays an entry, it is possible to use a For loop or other structure to redisplay the entry?

Thanks

Bye

@Echo Off
:loop
If %1' Equ ' (Echo=You didn't enter any parameters.
   GoTo :loop)

If %5' NEq ' (Echo=Too many parameters entered.
   GoTo :loop)

If %4' Equ ' (Echo=Insufficient parameters entered.
   GoTo :loop)

Rem Other code below here

foxidrive wrote:You had some typos:
= instead of ==
exit instead of exist

I'm not sure if this is what you are attempting to do:

Code: Select all

@echo off
:again
set "ESD_directory="
set /p "ESD_directory=Enter the directory where the esd unencrypted file will be inserted: "
if not defined ESD_directory goto :again
If not exist "%ESD_directory%\" md "%ESD_directory%"

balubeto wrote:I want to find an alternative solution to the one mentioned above without using the goto command to create the cycle.

• still have the cycle but without using goto
• not have the cycle

Compo wrote:

balubeto wrote:I want to find an alternative solution to the one mentioned above without using the goto command to create the cycle.

Are you wanting to

• still have the cycle but without using goto
• not have the cycle

balubeto wrote:Right.

So, I wait for a solution.

balubeto wrote:I want to find an alternative solution to the one mentioned above without using the goto command to create the cycle.

Compo wrote:

balubeto wrote:Right.

So, I wait for a solution.

You will be waiting a long time because you haven't told me which of the two options you require a solution for!

balubeto wrote:Excuse me, but this script

Code: Select all

echo/ & set ArgCount=0 & for %%i in (%*) do (set /a ArgCount+=1)
if %ArgCount% neq 4 (echo The arguments number is incorrect.) & goto end
:end

assumes that its arguments are insert directly from the command line. Now, I would like to create a script like this

Code: Select all

set /p Windows_Files_Path="Enter the directory in which put the content of the ^"Windows Setup Media^" volume image:"
set /p iso_Path="Enter the directory in which put the iso image file created:"
set /p esd_File_Path="Enter the directory in which put the esd unencrypted file:"
set /p esd_File="Enter the file to be converted which should be put in the %esd_File_Path% directory:"

that when it will be run, ask to enter the arguments.

How do I check whether the entered values are valid? If they are not valid, the script will have to immediately repeat the relative entry without using the goto command to create a loop.

1. You want to be able to accept arguments from the command line.
2. You want to be able to prompt for missing argument values.
3. You want to validate the values given, regardless of the source.
4. If an argument value is invalid, you want to require the user to enter a new value, and repeat until a valid argument is entered.

• Why do you need absolute instead of relative paths?
• What are ALL of the conditions that arguments need to meet to be valid?
• Why do you object to using the GOTO command?

douglas.swehla wrote:

balubeto wrote:Excuse me, but this script

Code: Select all

echo/ & set ArgCount=0 & for %%i in (%*) do (set /a ArgCount+=1)
if %ArgCount% neq 4 (echo The arguments number is incorrect.) & goto end
:end

assumes that its arguments are insert directly from the command line. Now, I would like to create a script like this

Code: Select all

set /p Windows_Files_Path="Enter the directory in which put the content of the ^"Windows Setup Media^" volume image:"
set /p iso_Path="Enter the directory in which put the iso image file created:"
set /p esd_File_Path="Enter the directory in which put the esd unencrypted file:"
set /p esd_File="Enter the file to be converted which should be put in the %esd_File_Path% directory:"

that when it will be run, ask to enter the arguments.

How do I check whether the entered values are valid? If they are not valid, the script will have to immediately repeat the relative entry without using the goto command to create a loop.

Here's what I'm hearing:

1. You want to be able to accept arguments from the command line.
2. You want to be able to prompt for missing argument values.
3. You want to validate the values given, regardless of the source.
4. If an argument value is invalid, you want to require the user to enter a new value, and repeat until a valid argument is entered.

Each of these things is very easy, but you are adding in some complications for no apparent reason.

To validate file and folder paths, it is usually enough to confirm that they exist, and if not, create them. You are asking to require absolute paths instead of relative, but aren't saying why. While this can be done, it's a bit of a pain, so we want to either understand what your use case is, so we can handle any other related weirdness, or explain to you why you don't need that, and keep the code simple and robust.

To do a repetitive task, you use a loop. If there are a fixed number of iterations, you use the FOR command. If there are an undefined, potentially infinite number of iterations like you are asking for, you use the GOTO command. That's what it's for. Some very competent people have suggested this already, and you are rejecting it without saying why. Before anyone invests time in creating and testing exotic solutions to avoid GOTO, you need to explain why it won't work for you.

So, to get the help you are asking for, please answer these questions:

• Why do you need absolute instead of relative paths?
• What are ALL of the conditions that arguments need to meet to be valid?
• Why do you object to using the GOTO command?

balubeto wrote:
The user will have to write the absolute path of the directory because this script will have to be placed in a different directory than of work.

The validity of the arguments will have to be compatible with that of symbols allowed by Windows 7 (or higher) for the creation of the file and directory names.

Thanks

Bye

balubeto wrote:

foxidrive wrote:You had some typos:
= instead of ==
exit instead of exist

I'm not sure if this is what you are attempting to do:

Code: Select all

@echo off
:again
set "ESD_directory="
set /p "ESD_directory=Enter the directory where the esd unencrypted file will be inserted: "
if not defined ESD_directory goto :again
If not exist "%ESD_directory%\" md "%ESD_directory%"

Does anyone know how to solve my problem in a more suitable form?

Thanks

Bye