Cannot perform a cyclic copy ERROR

[john924xps]

This is my program:

Code: Select all

@echo off
title Backup
color 0a
:varset
vld
set /p tocopy=Location of file/folder: 
set /p destination=Destination to copy to: 
echo.
echo Location: %tocopy%
echo Destination: %destination%
echo Agree?
set /p agree=(yes/no): 
if /i "%agree%"=="no" goto varset
if not exist "%destination%\BackupMainDir" md "%destination%\BackupMainDir"
set checknum=1
:checkfunc
if exist "%destination%\BackupMainDir\Backup %checknum%" (
set /a checknum=%checknum% + 1
goto checkfunc) else (
xcopy "%location%\*.*" "%destination%\BackupMainDir\Backup %checknum%" /s /h /e /k /f /c
pause)

It's meant to ask for a destination and location of the file to backup and the location to back up to. But I get this error? Help?

[foxidrive]

You are including the destination folder in the part that is being backed up. No can do.

That's when you get a cyclic copy error.

[foxidrive]

The flaw in your code looks to be that %location% is not set anywhere.

[Squashman]

%source% is usually a good variable name to use.

I am sure you will see your variable name mistake once you read your batch file.