Iterate volume letters to find ID

[wellard]

G'Day,

I have ugly code which does what i need: takes letter by letter (Z --> C) in system and check the volume ID ("XXXX-XXXX"). Once correct volume is found, letter is assigned a variable (tdrive) and script proceeds.

Here is a code:

Code: Select all

vol z: | find "XXXX-XXXX" >nul
if not errorlevel 1 (
set "tdrive=z:"
goto start
)

vol y: | find "XXXX-XXXX" >nul
if not errorlevel 1 (
set "tdrive=y:"
goto start
)

....

vol c: | find "XXXX-XXXX" >nul
if not errorlevel 1 (
set "tdrive=c:"
goto start
)

cls
echo. 
echo.
echo target drive NOT found,
echo.
echo operation aborted.
pause >nul
goto :eof

:start
...

In what way this code can be changed in order to preserve functionality, but occupy less place and become more professional?
(some kind of iteration...?)

[foxidrive]

Code: Select all

@echo off
set "tdrive="
for %%a in (z y x) do vol %%a: |find "blah" >nul && set tdrive=%%a:
echo tdrive is either "%tdrive%" or it's nul
pause

[wellard]

Ok, thanks a lot!

Currently code is following:

Code: Select all

@echo off
set "tdrive="
for %%a in (z y x w v u t s r q p o n m l k j i h g f e d c b a) do vol %%a: |find "blah" >nul && set tdrive=%%a:
if not defined tdrive echo drive not found & pause >nul & goto :eof
pause

Is it possible to replace (z y x w v u t s r q p o n m l k j i h g f e d c b a) part with regular expression (to go through every letter in alphabet)?

[Yury]

Is it possible to replace (z y x w v u t s r q p o n m l k j i h g f e d c b a) part with regular expression (to go through every letter in alphabet)?

Code: Select all

for /l %%# in (90 -1 65) do cmd /c exit /b %%#& 2>nul call vol %%=ExitCodeAscii%%:|>nul find "blah"&& call set tdrive=%%=ExitCodeAscii%%:

[foxidrive]

You win, Yury.

[Squashman]

I still vote for your code Foxidrive because it is more readable. No offense to you Yury. It is great code but a newbie to batch isn't going to understand what your code is doing.

[foxidrive]

I still vote for your code Foxidrive because it is more readable. No offense to you Yury. It is great code but a newbie to batch isn't going to understand what your code is doing.

I know what you mean Squashman, Yury provided what the OP asked for though, which is convoluted and obfuscated.

I get the impression that the OP has some other motive for asking the questions...

[wellard]

Code: Select all

for /l %%# in (90 -1 65) do cmd /c exit /b %%#& 2>nul call vol %%=ExitCodeAscii%%:|>nul find "blah"&& call set tdrive=%%=ExitCodeAscii%%:

Thanks a lot!