DosTips.com

penpen wrote:I think you have created the above batch using your script linked here.

The issue is caused by the (in your case unwanted) spaces at the end of the line:
These produce an infinit loop ("always encrypt2" on "if not "%userInput%"=="" goto encrypt2").

You could protect against them in different ways:
- When using set, just use doublequotes the definition of the environment variable, so the unwanted spaces don't harm your variable content; example:

Code: Select all

@echo off
setlocal enableExtensionsn enableDelayedExpansion
set a=a 
set "b=b" 
echo "%a%"
echo "%b%"
endlocal

- Don't echo to variable this way:

Code: Select all

echo abc >> test.txt
echo def >> test.txt
echo ghi >> test.txt

Instead doing it this way (so the extra spaces won't appear):

Code: Select all

> "test.txt" echo abc
>>"test.txt" echo def
>>"test.txt" echo ghi
:: or alternatively
> "test.txt" (
   echo abc
   echo def
   echo ghi
)

Sidenote: You should also protect filenames and pathes against spaces within them (by using doublequotes araound the filename as shown).


penpen

if /p variableExample==1 goto someWhere

echo set "char=%userInput:~0,1%" >> "%userprofile%\Documents\TheRivalsRage\Encrypt-Decrypt\functions\Encrypt.bat"
echo set "userInput=%userInput:~1%" >> "%userprofile%\Documents\TheRivalsRage\Encrypt-Decrypt\functions\Encrypt.bat"

set "char=~0,1userprofile\Documents\TheRivalsRage\Encrypt-Decrypt\functions\Encrypt.bat"
set "userInput=~1userprofile\Documents\TheRivalsRage\Encrypt-Decrypt\functions\Encrypt.bat"

Squashman wrote:Figure out your own error by debugging your program properly. Run it from a cmd prompt on turn echo on.

RedEyedRocker wrote:But these are the ones I can't protect and without protecting it, I can't echo them into a file.

CODE:

Code: Select all

echo set "char=%userInput:~0,1%" >> "%userprofile%\Documents\TheRivalsRage\Encrypt-Decrypt\functions\Encrypt.bat"
echo set "userInput=%userInput:~1%" >> "%userprofile%\Documents\TheRivalsRage\Encrypt-Decrypt\functions\Encrypt.bat"

I receive the following error.

ERROR:-

Code: Select all

set "char=~0,1userprofile\Documents\TheRivalsRage\Encrypt-Decrypt\functions\Encrypt.bat"
set "userInput=~1userprofile\Documents\TheRivalsRage\Encrypt-Decrypt\functions\Encrypt.bat"

>> "%userprofile%\Documents\TheRivalsRage\Encrypt-Decrypt\functions\Encrypt.bat" (
   echo set "char=%%userInput:~0,1%%"
   echo set "userInput=%%userInput:~1%%"
)

RedEyedRocker wrote:I found out that you can't protect these with double quotes as it will crash the program:

Code: Select all

if /p variableExample==1 goto someWhere

if /p "%%variableExample%%" == "1" goto someWhere

penpen wrote:

RedEyedRocker wrote:I found out that you can't protect these with double quotes as it will crash the program:

Code: Select all

if /p variableExample==1 goto someWhere

I guess you wanted to do something like this:

Code: Select all

if /p "%%variableExample%%" == "1" goto someWhere

penpen

echo set "char=%%userInput:~0,1%%" >> "%userprofile%\Documents\TheRivalsRage\Encrypt-Decrypt\functions\Encrypt.bat"
echo set "userInput=%%userInput:~1%%" >> "%userprofile%\Documents\TheRivalsRage\Encrypt-Decrypt\functions\Encrypt.bat"

RedEyedRocker wrote:

Squashman wrote:Figure out your own error by debugging your program properly. Run it from a cmd prompt on turn echo on.

That problem was already fixed, read carefully. I'm talking about my another problem.

Squashman wrote:

RedEyedRocker wrote:

Squashman wrote:Figure out your own error by debugging your program properly. Run it from a cmd prompt on turn echo on.

That problem was already fixed, read carefully. I'm talking about my another problem.

You show me in your thread where someone told you how to debug a batch file properly. You even said in your original post before you edited it that you could not see the error because the script would close to quickly. This means you were running your batch file with your mouse instead of running it from the cmd prompt. So YES. I READ THE WHOLE THREAD. I AM A MODERATOR. THAT IS MY JOB.