counting .bin files in a folder

[palireza]

Hello,
I am trying to count the number of .bin files in my folder that include a particular name pattern. I basically need to count how many such files I have for each name type.
For instance in my folder I have files like
Query.1.bin
Query.2.bin
Query.3.bin
and the response should be 3.
I have
set count=0
set pattern=Query.%%?%%.bin
for /f %%i in ('dir /b /a-d %pattern% ^| find /c /v ""') do @call set count=%%i

but my code does not recognize "?" and doesn't replace it with numbers and I get 0 in response.
I would really appreciate it if you can give some help on this.
Best
P.A.

[Squashman]

It thinks %?% is a variable name. Why do you have the percent signs in there?

[abc0502]

first,you don't need to use the pattern out side the for loop, and if you want the .bin files only there is no need for a pattern, but if you have another bin files that you don't want to be counted then use a pattern.

second you don't append the number to the count variable
code should look like this

Code: Select all

@echo off
set count=0
for /f "tokens=* delims=" %%a in ('Dir /B /A:-D "*.bin"') Do set /a count += 1
echo There is %count% .bin File(s)
pause

if want to use pattern (note the "Query.*.bin" instead of "*.bin" )

Code: Select all

@echo off
set count=0
for /f "tokens=* delims=" %%a in ('Dir /B /A:-D "Query.*.bin"') Do set /a count += 1
echo There is %count% .bin File(s)
pause

[Squashman]

I would agree with you on the * vs ?. If the file numbers were greater than 9 then it should not match.

He can use his original code as long has he removes the percent signs and uses the *.

Code: Select all

set count=0
set pattern=Query.*.bin
for /f %%i in ('dir /b /a-d %pattern% ^| find /c /v ""') do set count=%%i

[abc0502]

and he should also use the pattern in the for loop, there is no need to be out in separate variable.
and the "set count=0" there is no need for it as long he won't append numbers to it.

[palireza]

I did what you suggested and I got the correct answer, the only problem I have now is that when I rerun it, it gives me again zero. For some reason it only works one time and then cannot count again.

[palireza]

This is my revised code
set pattern=Query.*.bin
for /f "tokens=* delims=" %%i in ('Dir /B /A:-D %pattern%') do set /a count+=1
echo There is %count% .bin File(s)

[foxidrive]

This is my revised code
set pattern=Query.*.bin
for /f "tokens=* delims=" %%i in ('Dir /B /A:-D %pattern%') do set /a count+=1
echo There is %count% .bin File(s)

Does that work for you?

I assume your filenames actually contain percent signs, and that is a recipe for problems.

[abc0502]

you mixed many codes together, if you are going to use the "set /a count", then you have to "set count=0" before the for loop.
your first code is fine, just remove the "set count=0" & replace the "%%?%%" with "*"

and your's should work fine

[palireza]

Thank you guys! All fixed

[Squashman]

Thank you guys! All fixed

What was your final code?

[palireza]

set count=0
for /f "tokens=* delims=" %%i in ('Dir /B /A:-D "Query.*.bin"') do set /a count+=1

[Ed Dyreen]

set count=0
for /f "tokens=* delims=" %%i in ('Dir /B /A:-D "Query.*.bin"') do set /a count+=1

Why tokenizing ?

Code: Select all

for /f %%i in ('Dir /B /A:-D "Query.*.bin"') do set /a count+=1

why use for /f at all ?

Code: Select all

for %%? in ("Query.*.bin") do set /a count+=1
echo. %count% pattern matches relative to active directory.

[palireza]

Ed, I tried without token and /f and you were correct, it works without them fine.