help fix my code

[xhai]

Hi guys i have a code but i don't know how to fix it.. the problem is it doesn't display "Filesize is Mismatched!" when the bytesize is not equal..

The problem occur when the set file have <space> "DVD<space>2.iso".. it doesn't detect the space so it will work it the set file is "DVD.iso"

will this require extra codes?...

thank you i hope you fix my problem..

Code: Select all

:vSize
set file=DVD 2.iso
set bytesize=1673494528
FOR /F "usebackq" %%A IN ('%file%') DO set size=%%~zA
if %size% NEQ %bytesize% (set ERROR=1)
if defined ERROR (
echo.
echo                      Filesize is Mismatched!
echo.
TIMEOUT /t 2 >nul 
pause
goto start
) ELSE (
echo.
echo                      Filesize is Matched.
echo.
TIMEOUT /t 2 >nul 
)
goto vSize

[ShadowThief]

Code: Select all

set "file=DVD 2.iso"

[Squashman]

Why are you setting the error variable with an IF and then using an IF to check that variable. Why not just do all your logic in one if? If you are going to use the ERROR variable then you should clear it out before the IF statement that checks the sizes.

[penpen]

You should use a default for loop instead of the for/F loop and use double quotes:

Code: Select all

FOR %%A IN ("%file%") DO set size=%%~zA

penpen

[xhai]

You should use a default for loop instead of the for/F loop and use double quotes:

Code: Select all

FOR %%A IN ("%file%") DO set size=%%~zA

penpen

Thank you all and Mr.penpen the code works now..

can you explain me what is the difference between those codes..

[foxidrive]

can you explain me what is the difference between those codes..

Read the help from here and then ask any further questions you have: type this at the cmd prompt

FOR /?